Wednesday, December 24, 2008

Task: Code review

Reading and reviewing code is as important to learn programming, as is coding itself. In this task we will review some code instead of writing it.

Review the code of some other participant on Java Insights 101, and leave a comment on their blog describing your findings. Please be careful to be constructive while commenting on someone else's code. Mention the things you likes, and offer clear reasons for things you did not like. If possible, also offer alternative ways to implementing the code.

I have listed some parameters for reviewing code. You may choose to follow them, or you may choose to use your own list of parameters.
  • Correctness
  • Clarity (of code logic, variable names, class names, etc)
  • Adherence to good coding standards
  • Consistency
  • Good design principles
  • Simplicity
  • Test coverage
  • Usage as well as level of Log4J debug statement